[AutoPR azure-mgmt-fileshares]-generated-from-SDK Generation - Python-6256859#46749
Merged
ankushbindlish2 merged 6 commits intomainfrom May 7, 2026
Merged
Conversation
…FileShares/FileShares/tspconfig.yaml', and CommitSHA: '61f4dfae58f52c2c814ea7c6653ce77ac0cacd4a' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6256859 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
msyyc
requested review from
ChenxiJiang333,
lmazuel,
msyyc and
scbedd
as code owners
Closed
6 tasks
Member
|
test files are copied from #46602 |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a new management-plane Python package, azure-mgmt-fileshares, generated from the Microsoft.FileShares TypeSpec configuration, along with CI wiring and an initial set of tests/samples to support validation and future releases.
Changes:
- Added a new
sdk/filesharesservice directory with CI pipeline configuration and TypeSpec provenance (tsp-location.yaml). - Added the generated
azure-mgmt-filesharespackage (client, models, operations, async surface) plus metadata files (_metadata.json,apiview-properties.json,assets.json). - Added a mix of generated and hand-written tests/samples for CRUD, listing, snapshots, informational ops, and private endpoint surfaces.
Reviewed changes
Copilot reviewed 89 out of 91 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/fileshares/ci.yml | Adds service-directory CI pipeline definition for fileshares and publishes the azure-mgmt-fileshares artifact. |
| sdk/fileshares/azure-mgmt-fileshares/tsp-location.yaml | Records the source TypeSpec directory/repo/commit used to generate this package. |
| sdk/fileshares/azure-mgmt-fileshares/tests/test_fileshares_snapshots.py | Hand-written recorded tests covering snapshot CRUD and listing behavior. |
| sdk/fileshares/azure-mgmt-fileshares/tests/test_fileshares_private_endpoint.py | Hand-written recorded tests for private link resources and private endpoint connections listing. |
| sdk/fileshares/azure-mgmt-fileshares/tests/test_fileshares_operations.py | Hand-written (live-only) smoke test for operations.list(). |
| sdk/fileshares/azure-mgmt-fileshares/tests/test_fileshares_negative.py | Hand-written recorded negative-path tests for common error scenarios. |
| sdk/fileshares/azure-mgmt-fileshares/tests/test_fileshares_listing.py | Hand-written recorded tests for subscription/resource-group listing operations. |
| sdk/fileshares/azure-mgmt-fileshares/tests/test_fileshares_informational.py | Hand-written recorded tests for informational operations and name availability checks. |
| sdk/fileshares/azure-mgmt-fileshares/tests/test_fileshares_edge_cases.py | Hand-written recorded tests for name/tag/network edge cases. |
| sdk/fileshares/azure-mgmt-fileshares/tests/test_fileshares_crud.py | Hand-written (live-only) end-to-end CRUD test for FileShares. |
| sdk/fileshares/azure-mgmt-fileshares/tests/test_fileshares_complex_scenarios.py | Hand-written recorded tests for multi-resource and variant scenarios. |
| sdk/fileshares/azure-mgmt-fileshares/tests/conftest.py | Adds test-proxy sanitizers and disables specific batch sanitizers for name/id assertions. |
| sdk/fileshares/azure-mgmt-fileshares/tests/_fs_test_helpers.py | Shared helpers for the hand-written test suite (client creation, payload builders, cleanup, variable naming). |
| sdk/fileshares/azure-mgmt-fileshares/README.md | New package README with installation/authentication guidance and client snippet. |
| sdk/fileshares/azure-mgmt-fileshares/pyproject.toml | Defines package metadata, dependencies, dynamic version/readme, and packaging configuration. |
| sdk/fileshares/azure-mgmt-fileshares/MANIFEST.in | Ensures readme/license/typed marker and selected namespace init files are included in distributions. |
| sdk/fileshares/azure-mgmt-fileshares/LICENSE | Adds MIT license text for the package. |
| sdk/fileshares/azure-mgmt-fileshares/dev_requirements.txt | Development/test requirements for the package. |
| sdk/fileshares/azure-mgmt-fileshares/CHANGELOG.md | Introduces initial release entry 1.0.0b1. |
| sdk/fileshares/azure-mgmt-fileshares/azure/mgmt/fileshares/py.typed | Adds PEP 561 marker for typing support. |
| sdk/fileshares/azure-mgmt-fileshares/azure/mgmt/fileshares/operations/_patch.py | Customization hook scaffold for operations layer. |
| sdk/fileshares/azure-mgmt-fileshares/azure/mgmt/fileshares/operations/init.py | Exposes operation groups and wires patch hook. |
| sdk/fileshares/azure-mgmt-fileshares/azure/mgmt/fileshares/models/_patch.py | Customization hook scaffold for models layer. |
| sdk/fileshares/azure-mgmt-fileshares/azure/mgmt/fileshares/models/_enums.py | Generated enums for the FileShares RP. |
| sdk/fileshares/azure-mgmt-fileshares/azure/mgmt/fileshares/models/init.py | Exposes generated models/enums and wires patch hook. |
| sdk/fileshares/azure-mgmt-fileshares/azure/mgmt/fileshares/aio/operations/_patch.py | Async operations customization hook scaffold. |
| sdk/fileshares/azure-mgmt-fileshares/azure/mgmt/fileshares/aio/operations/init.py | Exposes async operation groups and wires patch hook. |
| sdk/fileshares/azure-mgmt-fileshares/azure/mgmt/fileshares/aio/_patch.py | Async client-layer customization hook scaffold. |
| sdk/fileshares/azure-mgmt-fileshares/azure/mgmt/fileshares/aio/_configuration.py | Generated async client configuration (policies, auth, api_version). |
| sdk/fileshares/azure-mgmt-fileshares/azure/mgmt/fileshares/aio/_client.py | Generated async management client for FileShares RP. |
| sdk/fileshares/azure-mgmt-fileshares/azure/mgmt/fileshares/aio/init.py | Async package exports and patch wiring. |
| sdk/fileshares/azure-mgmt-fileshares/azure/mgmt/fileshares/_version.py | Defines the package version constant (1.0.0b1). |
| sdk/fileshares/azure-mgmt-fileshares/azure/mgmt/fileshares/_validation.py | Generated API-version availability validation decorator. |
| sdk/fileshares/azure-mgmt-fileshares/azure/mgmt/fileshares/_utils/model_base.py | Generated model base/serialization utilities. |
| sdk/fileshares/azure-mgmt-fileshares/azure/mgmt/fileshares/_utils/init.py | Generated _utils package init. |
| sdk/fileshares/azure-mgmt-fileshares/azure/mgmt/fileshares/_patch.py | Sync client-layer customization hook scaffold. |
| sdk/fileshares/azure-mgmt-fileshares/azure/mgmt/fileshares/_configuration.py | Generated sync client configuration (policies, auth, api_version). |
| sdk/fileshares/azure-mgmt-fileshares/azure/mgmt/fileshares/_client.py | Generated sync management client for FileShares RP. |
| sdk/fileshares/azure-mgmt-fileshares/azure/mgmt/fileshares/init.py | Main package exports/version wiring and patch hook. |
| sdk/fileshares/azure-mgmt-fileshares/azure/mgmt/init.py | Namespace package init for azure.mgmt. |
| sdk/fileshares/azure-mgmt-fileshares/azure/init.py | Namespace package init for azure. |
| sdk/fileshares/azure-mgmt-fileshares/assets.json | Points to the assets repo tag containing recordings/artifacts for this package. |
| sdk/fileshares/azure-mgmt-fileshares/apiview-properties.json | APIView metadata including cross-language mappings. |
| sdk/fileshares/azure-mgmt-fileshares/_metadata.json | Generation metadata (apiVersion, emitter version, source commit/repo). |
| sdk/fileshares/azure-mgmt-fileshares/generated_tests/test_file_shares_mgmt_private_link_resources_operations.py | Auto-generated (skipped) sync tests scaffold for private link resources. |
| sdk/fileshares/azure-mgmt-fileshares/generated_tests/test_file_shares_mgmt_private_link_resources_operations_async.py | Auto-generated (skipped) async tests scaffold for private link resources. |
| sdk/fileshares/azure-mgmt-fileshares/generated_tests/test_file_shares_mgmt_private_endpoint_connections_operations.py | Auto-generated (skipped) sync tests scaffold for private endpoint connections. |
| sdk/fileshares/azure-mgmt-fileshares/generated_tests/test_file_shares_mgmt_private_endpoint_connections_operations_async.py | Auto-generated (skipped) async tests scaffold for private endpoint connections. |
| sdk/fileshares/azure-mgmt-fileshares/generated_tests/test_file_shares_mgmt_operations.py | Auto-generated (skipped) sync tests scaffold for operations. |
| sdk/fileshares/azure-mgmt-fileshares/generated_tests/test_file_shares_mgmt_operations_async.py | Auto-generated (skipped) async tests scaffold for operations. |
| sdk/fileshares/azure-mgmt-fileshares/generated_tests/test_file_shares_mgmt_informational_operations_operations.py | Auto-generated (skipped) sync tests scaffold for informational operations. |
| sdk/fileshares/azure-mgmt-fileshares/generated_tests/test_file_shares_mgmt_informational_operations_operations_async.py | Auto-generated (skipped) async tests scaffold for informational operations. |
| sdk/fileshares/azure-mgmt-fileshares/generated_tests/test_file_shares_mgmt_file_shares_operations.py | Auto-generated (skipped) sync tests scaffold for file shares operations. |
| sdk/fileshares/azure-mgmt-fileshares/generated_tests/test_file_shares_mgmt_file_shares_operations_async.py | Auto-generated (skipped) async tests scaffold for file shares operations. |
| sdk/fileshares/azure-mgmt-fileshares/generated_tests/test_file_shares_mgmt_file_share_snapshots_operations.py | Auto-generated (skipped) sync tests scaffold for snapshot operations. |
| sdk/fileshares/azure-mgmt-fileshares/generated_tests/test_file_shares_mgmt_file_share_snapshots_operations_async.py | Auto-generated (skipped) async tests scaffold for snapshot operations. |
| sdk/fileshares/azure-mgmt-fileshares/generated_tests/conftest.py | Auto-generated test-proxy sanitizers for generated tests. |
| sdk/fileshares/azure-mgmt-fileshares/generated_samples/private_link_resources_list_by_file_share.py | Auto-generated sample for listing private link resources. |
| sdk/fileshares/azure-mgmt-fileshares/generated_samples/private_link_resources_get.py | Auto-generated sample for getting a private link resource. |
| sdk/fileshares/azure-mgmt-fileshares/generated_samples/private_endpoint_connections_list_by_file_share.py | Auto-generated sample for listing private endpoint connections. |
| sdk/fileshares/azure-mgmt-fileshares/generated_samples/private_endpoint_connections_get.py | Auto-generated sample for getting a private endpoint connection. |
| sdk/fileshares/azure-mgmt-fileshares/generated_samples/private_endpoint_connections_delete.py | Auto-generated sample for deleting a private endpoint connection. |
| sdk/fileshares/azure-mgmt-fileshares/generated_samples/private_endpoint_connections_create.py | Auto-generated sample for creating a private endpoint connection. |
| sdk/fileshares/azure-mgmt-fileshares/generated_samples/operations_list_minimum_set_gen.py | Auto-generated sample for listing operations (minimum set). |
| sdk/fileshares/azure-mgmt-fileshares/generated_samples/operations_list_maximum_set_gen.py | Auto-generated sample for listing operations (maximum set). |
| sdk/fileshares/azure-mgmt-fileshares/generated_samples/file_shares_update_maximum_set_gen.py | Auto-generated sample for updating a file share (maximum set). |
| sdk/fileshares/azure-mgmt-fileshares/generated_samples/file_shares_list_by_subscription_minimum_set_gen.py | Auto-generated sample for listing shares by subscription (minimum set). |
| sdk/fileshares/azure-mgmt-fileshares/generated_samples/file_shares_list_by_subscription_maximum_set_gen.py | Auto-generated sample for listing shares by subscription (maximum set). |
| sdk/fileshares/azure-mgmt-fileshares/generated_samples/file_shares_list_by_parent_minimum_set_gen.py | Auto-generated sample for listing shares by resource group (minimum set). |
| sdk/fileshares/azure-mgmt-fileshares/generated_samples/file_shares_list_by_parent_maximum_set_gen.py | Auto-generated sample for listing shares by resource group (maximum set). |
| sdk/fileshares/azure-mgmt-fileshares/generated_samples/file_shares_get_maximum_set_gen.py | Auto-generated sample for getting a file share (maximum set). |
| sdk/fileshares/azure-mgmt-fileshares/generated_samples/file_shares_delete_maximum_set_gen.py | Auto-generated sample for deleting a file share (maximum set). |
| sdk/fileshares/azure-mgmt-fileshares/generated_samples/file_shares_create_or_update_maximum_set_gen.py | Auto-generated sample for creating/updating a file share (maximum set). |
| sdk/fileshares/azure-mgmt-fileshares/generated_samples/file_shares_check_name_availability_minimum_set_gen.py | Auto-generated sample for name availability check (minimum set). |
| sdk/fileshares/azure-mgmt-fileshares/generated_samples/file_shares_check_name_availability_maximum_set_gen.py | Auto-generated sample for name availability check (maximum set). |
| sdk/fileshares/azure-mgmt-fileshares/generated_samples/file_share_snapshot_update_maximum_set_gen.py | Auto-generated sample for updating snapshot metadata (maximum set). |
| sdk/fileshares/azure-mgmt-fileshares/generated_samples/file_share_snapshot_list_minimum_set_gen.py | Auto-generated sample for listing snapshots (minimum set). |
| sdk/fileshares/azure-mgmt-fileshares/generated_samples/file_share_snapshot_list_maximum_set_gen.py | Auto-generated sample for listing snapshots (maximum set). |
| sdk/fileshares/azure-mgmt-fileshares/generated_samples/file_share_snapshot_get_maximum_set_gen.py | Auto-generated sample for getting a snapshot (maximum set). |
| sdk/fileshares/azure-mgmt-fileshares/generated_samples/file_share_snapshot_delete_maximum_set_gen.py | Auto-generated sample for deleting a snapshot (maximum set). |
| sdk/fileshares/azure-mgmt-fileshares/generated_samples/file_share_snapshot_create_or_update_maximum_set_gen.py | Auto-generated sample for creating a snapshot (maximum set). |
| sdk/fileshares/azure-mgmt-fileshares/generated_samples/file_share_get_usage_data_minimum_set_gen.py | Auto-generated sample for usage data (minimum set). |
| sdk/fileshares/azure-mgmt-fileshares/generated_samples/file_share_get_usage_data_maximum_set_gen.py | Auto-generated sample for usage data (maximum set). |
| sdk/fileshares/azure-mgmt-fileshares/generated_samples/file_share_get_provisioning_recommendation_minimum_set_gen.py | Auto-generated sample for provisioning recommendation (minimum set). |
| sdk/fileshares/azure-mgmt-fileshares/generated_samples/file_share_get_provisioning_recommendation_maximum_set_gen.py | Auto-generated sample for provisioning recommendation (maximum set). |
| sdk/fileshares/azure-mgmt-fileshares/generated_samples/file_share_get_limits_minimum_set_gen.py | Auto-generated sample for limits (minimum set). |
| sdk/fileshares/azure-mgmt-fileshares/generated_samples/file_share_get_limits_maximum_set_gen.py | Auto-generated sample for limits (maximum set). |
…FileShares/FileShares/tspconfig.yaml', and CommitSHA: '75ca22c5387184fb1f0c3b115ed22a006813800d' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6257089 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
msyyc
approved these changes
May 6, 2026
Member
|
/azp run prepare-pipelines |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ChenxiJiang333
approved these changes
May 6, 2026
msyyc
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configurations: 'specification/fileshares/resource-manager/Microsoft.FileShares/FileShares/tspconfig.yaml', and CommitSHA: '61f4dfae58f52c2c814ea7c6653ce77ac0cacd4a' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6256859 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: Submitted by:
Release Plan Details